[Expression simplifcation] Improve error handling #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blattm
force-pushed
the
expression-simplifcation-error-handling
branch
from
0c81bd6 to
83252d9
Compare
blattm
reviewed
Oct 19, 2023
decompiler/pipeline/controlflowanalysis/expression_simplification/constant_folding.py
Show resolved
Hide resolved
decompiler/pipeline/controlflowanalysis/expression_simplification/constant_folding.py
Show resolved
Hide resolved
decompiler/pipeline/controlflowanalysis/expression_simplification/constant_folding.py
Show resolved
Hide resolved
decompiler/pipeline/controlflowanalysis/expression_simplification/constant_folding.py
Show resolved
Hide resolved
decompiler/pipeline/controlflowanalysis/expression_simplification/rules/collapse_constants.py
Outdated
Show resolved
Hide resolved
...er/pipeline/controlflowanalysis/expression_simplification/rules/collapse_nested_constants.py
Show resolved
Hide resolved
decompiler/pipeline/controlflowanalysis/expression_simplification/constant_folding.py
Show resolved
Hide resolved
...er/pipeline/controlflowanalysis/expression_simplification/rules/collapse_nested_constants.py
Outdated
Show resolved
Hide resolved
...er/pipeline/controlflowanalysis/expression_simplification/rules/collapse_nested_constants.py
Show resolved
Hide resolved
decompiler/pipeline/controlflowanalysis/expression_simplification/stages.py
Outdated
Show resolved
Hide resolved
blattm
previously approved these changes
Oct 25, 2023
blattm
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr improves the error handling of the expression simplifcation stage, especially with collapsing of constants. Previously there were some exceptions, which were being thrown on valid input data, like adding of pointer constants with integer constants.
Additionally all errors caused by simplification rules are now catched and properly handled.